Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for Apple Silicon #479

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

ashao
Copy link
Member

@ashao ashao commented Feb 7, 2024

docs.tgz

Separate instructions are now included for Mac OSX on Apple Silicon. The most important:

  • core.autoclrf=true when cloning SmartSim to avoid errors when building due to line-ending conventions during the Redis build
  • Only PyTorch is supported for that platform

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than OSX vs MacOS, LGTM

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18fe50a) 90.55% compared to head (805d246) 90.85%.
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #479      +/-   ##
===========================================
+ Coverage    90.55%   90.85%   +0.29%     
===========================================
  Files           60       60              
  Lines         3821     3826       +5     
===========================================
+ Hits          3460     3476      +16     
+ Misses         361      350      -11     

see 4 files with indirect coverage changes

git clone https://github.com/CrayLabs/SmartSim smartsim
.. code-block:: bash

git clone --config core.autocrlf=true https://github.com/CrayLabs/SmartSim smartsim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I may have also beeen forced to ensure that non-mac gcc came before mac version in path. must verify...

@ashao ashao merged commit 9015bd8 into CrayLabs:develop Feb 13, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants