-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions for Apple Silicon #479
Conversation
2b85530
to
a732309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than OSX vs MacOS, LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #479 +/- ##
===========================================
+ Coverage 90.55% 90.85% +0.29%
===========================================
Files 60 60
Lines 3821 3826 +5
===========================================
+ Hits 3460 3476 +16
+ Misses 361 350 -11 |
git clone https://github.com/CrayLabs/SmartSim smartsim | ||
.. code-block:: bash | ||
|
||
git clone --config core.autocrlf=true https://github.com/CrayLabs/SmartSim smartsim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have also beeen forced to ensure that non-mac gcc came before mac version in path. must verify...
docs.tgz
Separate instructions are now included for Mac OSX on Apple Silicon. The most important:
core.autoclrf=true
when cloning SmartSim to avoid errors when building due to line-ending conventions during the Redis build