Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index when installing torch through smart build #449

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

ashao
Copy link
Member

@ashao ashao commented Jan 5, 2024

Torch changed something in their indexing when trying to install from their provided wheels. This updates the pip install command within smart build to ensure that the appropriate packages can be found.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (142ddc1) 90.34% compared to head (73846b9) 90.42%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #449      +/-   ##
===========================================
+ Coverage    90.34%   90.42%   +0.08%     
===========================================
  Files           60       60              
  Lines         3748     3738      -10     
===========================================
- Hits          3386     3380       -6     
+ Misses         362      358       -4     

see 3 files with indirect coverage changes

Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashao ashao merged commit 8fd7160 into CrayLabs:develop Jan 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants