Make some Slurm errors fatal for execution #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #392 +/- ##
===========================================
+ Coverage 90.11% 90.24% +0.12%
===========================================
Files 60 60
Lines 3864 3864
===========================================
+ Hits 3482 3487 +5
+ Misses 382 377 -5 |
al-rigazzi
added
type: design
ankona
reviewed
Oct 13, 2023
al-rigazzi
changed the title
ankona
approved these changes
Oct 24, 2023
MattToast
requested changes
Oct 24, 2023
MattToast
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
LGTM pending a re-run of tests after the merge of the CrayLabs/SmartRedis#421 hotfix!
OK thanks, I'll let other - more urgent - PRs get in before this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Slurm-based systems, it can happen that some commands are available, but return an error when the SlurmDB does not work properly. This error could silently lead to SmartSim's execution looping forever. It was decided that any error on
sacctwill be fatal for execution, as SmartSim makes use ofsacctto acquire information about running , paused,and finished jobs.