Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Slurm heterogeneous jobs #346

Merged
merged 20 commits into from
Aug 25, 2023
Merged

Add support for Slurm heterogeneous jobs #346

merged 20 commits into from
Aug 25, 2023

Commits on Aug 23, 2023

  1. Add feature and prevent single_cmd orch

    @al-rigazzi
    al-rigazzi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    719380b View commit details
    Browse the repository at this point in the history

  2. Prevent MPMD in slurm het jobs

    @al-rigazzi
    al-rigazzi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1d7ad3e View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @al-rigazzi
    al-rigazzi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    dc03213 View commit details
    Browse the repository at this point in the history

  4. Lint again

    @al-rigazzi
    al-rigazzi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c7277f3 View commit details
    Browse the repository at this point in the history

  5. More lint

    @al-rigazzi
    al-rigazzi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c098460 View commit details
    Browse the repository at this point in the history

  6. Add het job functionality tests

    @al-rigazzi
    al-rigazzi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b80281e View commit details
    Browse the repository at this point in the history

  7. Add test

    @al-rigazzi
    al-rigazzi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d98b006 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Include MattToast's suggestion 

    Co-authored-by: Matt Drozt <[email protected]>
    @al-rigazzi @MattToast
    al-rigazzi and MattToast authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a56174b View commit details
    Browse the repository at this point in the history

  2. Include MattToast's other suggestion 

    Co-authored-by: Matt Drozt <[email protected]>
    @al-rigazzi @MattToast
    al-rigazzi and MattToast authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    672206b View commit details
    Browse the repository at this point in the history

  3. Move het hob tests to main test dir

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    098d9c4 View commit details
    Browse the repository at this point in the history

  4. Add back tests

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    354873b View commit details
    Browse the repository at this point in the history

  5. Fix wrong single cmd handling

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3551c46 View commit details
    Browse the repository at this point in the history

  6. Lint, lint everywhere

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    29d11e0 View commit details
    Browse the repository at this point in the history

  7. Lint check broken here

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    dd23a71 View commit details
    Browse the repository at this point in the history

  8. Move test to on_wlm

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    bc7e211 View commit details
    Browse the repository at this point in the history

  9. Add het size check as per Chris McBride's request

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e62f649 View commit details
    Browse the repository at this point in the history

  10. Fix implicit cast

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    67bb3e3 View commit details
    Browse the repository at this point in the history

  11. Better handling of cast

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    40602af View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary else

    @al-rigazzi
    al-rigazzi committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7313f45 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'develop' of https://github.com/CrayLabs/SmartSim into s… 

    …lurm-het-jobs
    @al-rigazzi
    al-rigazzi committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    32f38fa View commit details
    Browse the repository at this point in the history