-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation surrounding contributions #344
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #344 +/- ##
===========================================
- Coverage 87.31% 87.04% -0.27%
===========================================
Files 59 59
Lines 3531 3551 +20
===========================================
+ Hits 3083 3091 +8
- Misses 448 460 +12 |
05faf5f
to
dfd3267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo to fix, then LGTM! Great stuff!
Corrected a typo that I saw. Otherwise looks great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pulls together and creates some new guidelines on how to contribute to SmartSim.