Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation surrounding contributions #344

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

ashao
Copy link
Member

@ashao ashao commented Aug 22, 2023

Pulls together and creates some new guidelines on how to contribute to SmartSim.

@ashao ashao added the area: docs Issues related to documentation label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #344 (eb03852) into develop (f9e17f0) will decrease coverage by 0.27%.
Report is 10 commits behind head on develop.
The diff coverage is n/a.

❗ Current head eb03852 differs from pull request most recent head 923839a. Consider uploading reports for the commit 923839a to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #344      +/-   ##
===========================================
- Coverage    87.31%   87.04%   -0.27%     
===========================================
  Files           59       59              
  Lines         3531     3551      +20     
===========================================
+ Hits          3083     3091       +8     
- Misses         448      460      +12     

@ashao ashao requested a review from ankona August 23, 2023 16:05
@ashao ashao removed the request for review from al-rigazzi August 23, 2023 16:49
Copy link
Contributor

@juliaputko juliaputko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo to fix, then LGTM! Great stuff!

doc/contributing.rst Outdated Show resolved Hide resolved
@billschereriii
Copy link
Contributor

Corrected a typo that I saw. Otherwise looks great

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashao ashao merged commit 96305f2 into CrayLabs:develop Sep 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants