-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitigate suppressed protected-access errors from pylint #341
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #341 +/- ##
===========================================
- Coverage 87.31% 87.25% -0.06%
===========================================
Files 59 59
Lines 3531 3546 +15
===========================================
+ Hits 3083 3094 +11
- Misses 448 452 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing these lint suppressions. It seems like DBModel
and DBScript
are more visible to the user now that they are properties. Do you think it's worth making a ticket to look through these objects and make sure they have basic user-functionality for inspection (e.g. __str__
).
Ticket 511 created @mellis13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thanks!
Mitigate the following protected-access errors & remove suppression:
EntityList._db_models
-> adddb_models
property returning immutable collectionEntityList._db_scripts
-> adddb_scripts
property returning immutable collectionModel._db_models
-> adddb_models
property returning immutable collectionModel._db_scripts
-> adddb_scripts
property returning immutable collectionModel.add_ml_model_object
passthrough to_append_db_model
EntityList.add_ml_model_object
passthrough to_append_db_model
BatchSettings._preamble
-> addpreamble
property returning immutable collection