-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter launchers to pass env when starting a local step #329
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #329 +/- ##
===========================================
- Coverage 87.30% 87.18% -0.13%
===========================================
Files 59 59
Lines 3522 3518 -4
===========================================
- Hits 3075 3067 -8
- Misses 447 451 +4
|
add slurm-wlm test for local steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes to ensure that the test doesn't fail on non-slurm machines. Other question, do you want to reserve adding tests for the other WLMs for later? It's a little challenging because of the combinations of WLMs and run commands
Thanks for digging into this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Let's hold off on adding PBS+aprun tests since it might be a little harder to detect the availability of aprun.
This ticket ensures that an experiment with a workload manager will pass environment variables to unmanaged steps. This edge case occurs if a developer manually creates and attach a
RunSettings
instance instead of using theexperiment.create_run_settings
factory method.Changes include:
LocalStep
environment is passed to task manager when task is unmanaged by launcher