-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor smart cli into subparsers #308
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #308 +/- ##
===========================================
- Coverage 87.12% 86.95% -0.18%
===========================================
Files 59 59
Lines 3518 3518
===========================================
- Hits 3065 3059 -6
- Misses 453 459 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! All of the help statements are now correct, and I love the clean up to remove the (imo unnecessary) classes and shift this to a more procedural/functional style! It should make testing much easier!!
I found a couple small knit picks, the most major being that there seems to be a type error being raised when installing for GPU. Otherwise, all other functionality seems to be working as I would expect it to!!
Thanks for the hard work on this one!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thanks for this refactor, this should be much nicer to work with!!
Separate creation of the sub-command parsers from parser execution and decouple CLI definition & instantiation.