Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor random_permutations for simplicity #300

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jun 6, 2023

Small refactor of random_permutations to simplify code.

Notes:

  • Given thatlist(product(*param_values)) was called prior to the sampling code, I assume that the permutation count is manageable.
  • Since the original code used a set to identify already retrieved permutations, random.sample (sample without replacement) should work identically

Copy link
Contributor

@billschereriii billschereriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just don't forget to update the changelog

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #300 (bdca186) into develop (395ffb0) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head bdca186 differs from pull request most recent head a566c64. Consider uploading reports for the commit a566c64 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #300      +/-   ##
===========================================
- Coverage    87.87%   87.79%   -0.09%     
===========================================
  Files           59       59              
  Lines         3390     3383       -7     
===========================================
- Hits          2979     2970       -9     
- Misses         411      413       +2     
Impacted Files Coverage Δ
smartsim/entity/strategies.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ankona ankona force-pushed the rand_perm branch 2 times, most recently from bdca186 to b544e68 Compare June 13, 2023 22:30
alpha-reorder imports

fix broken import

update changelog
@ankona ankona merged commit 3f2dfa4 into CrayLabs:develop Jun 15, 2023
@ankona ankona deleted the rand_perm branch June 15, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants