Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify attach_generator_files() doc strings #287

Merged
merged 1 commit into from
May 24, 2023

Conversation

mellis13
Copy link
Contributor

This is a small clarification of the doc strings for attach_generator_files that clearly states multiple calls will overwrite files.

@mellis13 mellis13 requested a review from MattToast May 24, 2023 00:20
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #287 (5b0c3fc) into develop (7434157) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #287      +/-   ##
===========================================
+ Coverage    87.52%   87.70%   +0.17%     
===========================================
  Files           60       60              
  Lines         3374     3374              
===========================================
+ Hits          2953     2959       +6     
+ Misses         421      415       -6     
Impacted Files Coverage Δ
smartsim/entity/model.py 97.14% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear, lgtm!!

@mellis13 mellis13 merged commit 564b581 into CrayLabs:develop May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants