Updates Fortran documentation for error codes #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billschereriii
suggested changes
May 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #284 +/- ##
===========================================
- Coverage 87.70% 87.58% -0.12%
===========================================
Files 60 60
Lines 3374 3374
===========================================
- Hits 2959 2955 -4
- Misses 415 419 +4 |
|
I'm going to wait until #285 is merged so we get a clean pass on the CI. |
The examples in the Fortran documentation examples used a mixture of subroutines and functions. The former was deprecated when error handling was implemented to allow the clients to bubble up a return code that Fortran applications can check. This has now been updated to allow others to use the documents as an accurate jumping off point.
Grep for and looking for that string
ashao
force-pushed
the
update_fortran_example
branch
from
4d547f4
to
db7032d
Compare
billschereriii
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples in the Fortran documentation examples used a mixture of subroutines and functions. The former was deprecated when error handling was implemented to allow the clients to bubble up a return code that Fortran applications can check. This has now been updated to allow others to use the documents as an accurate jumping off point.
Closes CrayLabs/SmartRedis#335