Support for site-provided dependencies #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the SMARTSIM_DEP_PATH environment variable has been set. Base some of the SmartSim dependencies on that variable instead of the locally installed libraries.
Create a separate build method for users who have a site-managed SmartSim installation since most dependencies and libraries will be handled by the site administrator.
ashao
force-pushed
the
smartsim_site_build
branch
2 times, most recently
from
d7756de
to
63a6a51
Compare
Including a printer for Versioner would require tabulate as an additional dependency. For now, this functionality has been removed to avoid errors when installing via pip.
ashao
force-pushed
the
smartsim_site_build
branch
from
63a6a51
to
7f9cff0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #182 +/- ##
========================================
Coverage 81.73% 81.74%
========================================
Files 57 57
Lines 2973 2974 +1
========================================
+ Hits 2430 2431 +1
Misses 543 543
|
Replace the sitebuild functionality with a `--only_python_packages` variant of `smart build`. This will also issue a warning for a case where a user might accidentally omit the device flag (which defaults to cpu) and not install the GPU variant of torch.
In cases where SmartSim dependencies are provided by the system, allow Builder objects to detect those locations.
Spartee
suggested changes
Apr 11, 2022
Spartee
approved these changes
Apr 20, 2022
al-rigazzi
pushed a commit
to al-rigazzi/SmartSim
that referenced
this pull request
May 16, 2022
Support for site-provided dependencies Include an optional argument`--only_python_packages` to to `smart build`. This will also issue a warning for a case where a user might accidentally omit the device flag (which defaults to cpu) and not install the GPU variant of torch. The config can now also detect whether dependencies are available elsewhere on the platform. If so, those libraries and executables are not built installed within the user's conda environment. Reviewed by @Spartee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a new function in the
smartCLI to aid users whose site admins provide most of the packages. Additionally, if the appropriate environment variables are set, SmartSim will be configured to acknowledge the sitewide package installations.