-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ML online training tutorial #176
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #176 +/- ##
===========================================
+ Coverage 81.20% 81.43% +0.23%
===========================================
Files 57 57
Lines 2910 2968 +58
===========================================
+ Hits 2363 2417 +54
- Misses 547 551 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny comment, but I'm approving this. I think we could open 1 more ticket about getting this into the smartsim-tutorials container, but I feel like thats outside the scope of this ticket.
input_names = [x.name.split(":")[0] for x in frozen_func.inputs] | ||
output_names = [x.name.split(":")[0] for x in frozen_func.outputs] | ||
|
||
model_serialized = frozen_func.graph.as_graph_def().SerializeToString(deterministic=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be an option? I'm guessing no but want to be sure.
Added a test for the new function, coverage is stable (small increase). |
This PR substitutes the old ML training tutorials with a new one.
The major features of this tutorial:
The whole training is performed in Keras, the PyTorch version will be ready soon.