-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add directory support for generator to_configure parameter #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work. Mostly style- and docstring-related comments. I like the TaggedFilesHierarchy
class and its mechanisms. Good work!
Changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple changes requested, but overall looks great. Using Pathlib
could make your life a little easier here, but I'll leave that up to you.
Some things I would like to see are more tests that cause the errors to be raised. (Some adversarial examples)
Let me know if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!! LGTM. Great work. thanks for responding to the feedback!
Overriding review as Al is on vacation
Changes in
files.py
TaggedFilesHierarchy
class to build a tree of directories of files that need to be configuredEntityFiles.tagged_hierarchy
property, to assign aTaggedFilesHierarchy
object to after checking theEntityFiles.tagged
filesEntityFiles.tagged_hierarchy
inEntityFiles._check_files
methodChanges in
generator.py
Generator._write_tagged_entity_files
Replace loop over list of file paths with a DFS overTaggedFilesHierarchy