Remove Pandas from experiment summary #116
Conversation
MattToast
changed the title
There was a problem hiding this comment.
hey Matt! great stuff on the PR!
A couple comments
theres a test in on_wlm/test_simple_entity_launch.py that tests the summary function and will need to be changed. In addition, we should add another test in the test_experiment.py file to test another simple run.
…ty_launch.py summary test
Merge remote-tracking branch 'upstream/develop' into remove_np_from_experiment_summary
|
Changes:
|
| @@ -467,35 +467,35 @@ def summary(self): | |||
| The summary will show each instance that has been | |||
| launched and completed in this ``Experiment`` | |||
|
|
|||
| :return: pandas Dataframe of ``Experiment`` history | |||
| :rtype: pd.DataFrame | |||
| :return: tabulate string of ``Experiment`` history | |||
There was a problem hiding this comment.
Lets allow format as a parameter here and pass to the tabulate function. Also should add in https://github.com/astanin/python-tabulate#table-format to the docstring so that people know what options are available.
smartsim/experiment.py
Outdated
| job.history.returns[run], | ||
| ] | ||
| ) | ||
| return tabulate(values, headers, showindex=True, tablefmt="plain") |
There was a problem hiding this comment.
lets set the default to github. so the added parameter will be a keyword arg like format=github and then that input parameter will be passed here.
|
Changes:
|
…t_summary Bring up to date with upstream
Experiment.summarymethod by removing usage of a pandas dataframe and instead utilizing tabulate to format the summary table