Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment.create_batch_settings #112

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Conversation

Spartee
Copy link
Contributor

@Spartee Spartee commented Nov 21, 2021

Description

create_batch_settings is a portability improvement for users writing driver scripts.

With this function, a user no longer needs to specify a batch settings class, the function will initialize a given class based on the launcher

TODO

  • Refactor the batch (full_wlm) tests

Sam Partee added 3 commits November 21, 2021 16:49
create_batch_settings is a portability improvement
for users writing driver scripts.

With this function, a user no longer needs to specify
a batch settings class, the function will initialize
a given class based on the launcher
Before, there was a single generic batch test for
Slurm and little coverage of other WLM types. With
the addition of the portable create_batch_settings
function, this test will now execute on any of the
supported launchers.
Added ``set_queue`` to BsubBatchSettings
and added a test for LSF
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should create a follow-up ticket for LSF

@Spartee Spartee merged commit 79feee5 into CrayLabs:develop Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants