Skip to content

Commit

Permalink
Restrict to numpy 1.x (#623)
Browse files Browse the repository at this point in the history
The new major version release of Numpy is incompatible with modules
compiled against Numpy 1.x. For both SmartSim and SmartRedis we request
a 1.x version of numpy. This is needed in SmartSim because some of the
downstream dependencies request NumPy.

[ committed by @ashao ]
[ reviewed by @al-rigazzi ]
  • Loading branch information
ashao authored Jun 25, 2024
1 parent 0956399 commit 8423eb4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions doc/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,19 @@ To be released at some future point in time

Description

- Pin NumPy version to 1.x
- New launcher support for SGE (and similar derivatives)
- Fix test outputs being created in incorrect directory
- Improve support for building SmartSim without ML backends
- Update packaging dependency

Detailed Notes

- The new major version release of Numpy is incompatible with modules
compiled against Numpy 1.x. For both SmartSim and SmartRedis we
request a 1.x version of numpy. This is needed in SmartSim because
some of the downstream dependencies request NumPy
([SmartSim-PR623](https://github.com/CrayLabs/SmartSim/pull/623))
- SGE is now a supported launcher for SmartSim. Users can now define
BatchSettings which will be monitored by the TaskManager. Additionally,
if the MPI implementation was built with SGE support, Orchestrators can
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ def has_ext_modules(_placeholder):
"pydantic==1.10.14",
"pyzmq>=25.1.2",
"pygithub>=2.3.0",
"numpy<2"
]

# Add SmartRedis at specific version
Expand Down

0 comments on commit 8423eb4

Please sign in to comment.