Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-593 Fix collapse to function bugs #600

Merged
merged 1 commit into from
Jul 27, 2024
Merged

GH-593 Fix collapse to function bugs #600

merged 1 commit into from
Jul 27, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Jul 27, 2024

Fixes #593

  • Pins should retain type
  • Multiple pins should not have the same name
  • Optional return node
  • Script function call nodes use argument namse

@Naros
CraterCrashGH-593 Fix collapse to function bugs
73fe45b 
- Pins should retain type
- Multiple pins should not have the same name
- Optional return node
- Script function call nodes use argument namse
@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 27, 2024
@Naros Naros added this to the 2.1 milestone Jul 27, 2024
@Naros Naros merged commit b7e2622 into CraterCrash:main Jul 27, 2024
8 checks passed
@Naros Naros deleted the GH-593 branch July 27, 2024 19:20
@Naros
Copy link
Member Author

Naros commented Jul 27, 2024

Applied to main (=2.1) and branch 2.0.

@Naros Naros removed the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Collapse to function looses pin type details & doesn't assign unique pin names
1 participant
@Naros