Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation on property get/set nodes often fails under specific conditions #800

Closed
Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #801
Closed

Validation on property get/set nodes often fails under specific conditions #800

Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #801
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.

Comments

@Naros
Copy link
Member

Naros commented Sep 7, 2024

Describe the bug

The property get/set node is designed to do a bit of dynamic lookup for property accessors/mutators related to target objects, such as other nodes or scripts, or when being accessed via node paths. This dynamic lookup often causes validation failures when the user may have another scene open that doesn't have the node path or may fail if the user copies the get/set property node from another graph into a context where the resolution cannot happen, like inside a user-defined function.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.1.stable / 2.0.3.stable

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. labels Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-800 Temporarily disable some property get/set validatio…
9fecb12 
…n rules
@Naros Naros mentioned this issue Sep 7, 2024
Merged
Naros added a commit that referenced this issue Sep 7, 2024
@Naros
GH-800 Temporarily disable some property get/set validation rules
57c0207
@Naros Naros closed this as completed in #801 Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-800 Temporarily disable some property get/set validatio…
9e236a4 
…n rules
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-800 Temporarily disable some property get/set validatio…
3954e86 
…n rules
@Naros Naros mentioned this issue Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-800 Temporarily disable some property get/set validation rules Naros/godot-orchestrator
1 participant
@Naros