Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder script instance uses VariantUtils::evaluate incorrectly #794

Closed
Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #795
Closed

Placeholder script instance uses VariantUtils::evaluate incorrectly #794

Naros opened this issue Sep 7, 2024 · 0 comments · Fixed by #795
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Sep 7, 2024

Describe the bug

The OScriptPlaceHolderInstance::set uses the VariantUtils::evaluate method; however, it bases its logic on the validity result rather than the equality/in-equality result. It should be based on the operator result instead.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

4.3.stable

Orchestrator version

2.1.1.stable / 2.0.3.stable

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. labels Sep 7, 2024
@Naros Naros added this to the 2.2 milestone Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-794 Fix default value evaluation in ScriptPlaceHolderIn…
f53b762 
…stance
@Naros Naros mentioned this issue Sep 7, 2024
Merged
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-794 Fix default value evaluation in ScriptPlaceHolderIn…
3ed731f 
…stance
Naros added a commit that referenced this issue Sep 7, 2024
@Naros
GH-794 Fix default value evaluation in ScriptPlaceHolderInstance
d5558ee
@Naros Naros closed this as completed in #795 Sep 7, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-794 Fix default value evaluation in ScriptPlaceHolderIn…
49b90bd 
…stance
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-794 Fix default value evaluation in ScriptPlaceHolderIn…
aa9fb2b 
…stance
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 7, 2024
@Naros
CraterCrashGH-794 Fix default value evaluation in ScriptPlaceHolderIn…
0fa3153 
…stance
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-794 Fix default value evaluation in ScriptPlaceHolderInstance
a51c7b6
Naros added a commit that referenced this issue Oct 5, 2024
@Naros
GH-794 Fix default value evaluation in ScriptPlaceHolderInstance
d7fa88a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-794 Fix default value evaluation in ScriptPlaceHolderInstance Naros/godot-orchestrator
1 participant
@Naros