Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing variable to non-object type should absolve validated flag #756

Closed
Naros opened this issue Aug 17, 2024 · 0 comments · Fixed by #757
Closed

Changing variable to non-object type should absolve validated flag #756

Naros opened this issue Aug 17, 2024 · 0 comments · Fixed by #757
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Aug 17, 2024

Describe the bug

The VariableGet node can be rendered with a validated flavor when the variable type is an Object-based type. However, when the variable type is later changed to a non-Object type, the VariableGet should be converted to a pure getter without validation automatically on the type change.

Expected behavior

Validated getter only applies to Object-based types.

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.stable / 2.0.2.stable

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 labels Aug 17, 2024
@Naros Naros added this to the 2.2 milestone Aug 17, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 17, 2024
@Naros
CraterCrashGH-756 Fix validated getter state consistency
cc0abda
@Naros Naros mentioned this issue Aug 17, 2024
Merged
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 17, 2024
@Naros
CraterCrashGH-756 Fix validated variable getter state consistency
bd17c76
Naros added a commit that referenced this issue Aug 18, 2024
@Naros
GH-756 Fix validated variable getter state consistency
3bccbb6
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 18, 2024
@Naros
CraterCrashGH-756 Fix validated variable getter state consistency
3aed14b
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 18, 2024
@Naros
CraterCrashGH-756 Fix validated variable getter state consistency
e99a20e
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 19, 2024
@Naros
CraterCrashGH-756 Fix validated variable getter state consistency
33dac8a
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 19, 2024
@Naros
CraterCrashGH-756 Fix validated variable getter state consistency
ed31e69
Naros added a commit that referenced this issue Aug 25, 2024
@Naros
GH-756 Fix validated variable getter state consistency
4e3e99f
Naros added a commit that referenced this issue Aug 25, 2024
@Naros
GH-756 Fix validated variable getter state consistency
ad93e6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-756 Fix validated variable getter state consistency Naros/godot-orchestrator
1 participant
@Naros