Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update picker does not trigger between 2.1.rc4 and 2.1.stable #743

Closed
Naros opened this issue Aug 15, 2024 · 0 comments · Fixed by #744
Closed

Update picker does not trigger between 2.1.rc4 and 2.1.stable #743

Naros opened this issue Aug 15, 2024 · 0 comments · Fixed by #744
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Aug 15, 2024

Describe the bug

The issue is that the logic in the is_after method is incorrect and does not account for all corner cases. This leads to the algorithm returning that there are no updates when 2.1.stable does exist.

Expected behavior

Should have reported 2.1.stable has an update.

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.stable / 2.1.rc4

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 labels Aug 15, 2024
@Naros Naros added this to the 2.2 milestone Aug 15, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 15, 2024
@Naros
CraterCrashGH-743 Fix update picker is_after logic
c391005
@Naros Naros mentioned this issue Aug 15, 2024
Merged
@Naros Naros pinned this issue Aug 15, 2024
Naros added a commit that referenced this issue Aug 15, 2024
@Naros
GH-743 Fix update picker is_after logic
ad909cf
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 15, 2024
@Naros
CraterCrashGH-743 Fix update picker is_after logic
f3ceb16
Naros added a commit that referenced this issue Aug 15, 2024
@Naros
GH-743 Fix update picker is_after logic
ac21842
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 19, 2024
@Naros
CraterCrashGH-743 Fix update picker is_after logic
ce80825
Naros added a commit that referenced this issue Aug 25, 2024
@Naros
GH-743 Fix update picker is_after logic
57dc0bb
@Naros Naros unpinned this issue Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-743 Fix update picker is_after logic Naros/godot-orchestrator
1 participant
@Naros