Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+x does not work in EventGraph #714

Closed
dschiller opened this issue Aug 11, 2024 · 2 comments · Fixed by #751
Closed

Ctrl+x does not work in EventGraph #714

dschiller opened this issue Aug 11, 2024 · 2 comments · Fixed by #751
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior. requires/godot-change Requires a change to upstream Godot.
Milestone
2.2

Comments

@dschiller
Copy link

dschiller commented Aug 11, 2024 •
edited
Loading

Describe the bug

Removing nodes inside a EventGraph via Ctrl+x does not work.

Expected behavior

Ctrl+x should work inside a EventGraph whit a selected node.

Actual behavior

Ctrl+x does not remove the selected node inside a EventGraph. Or when an item in the Scene Dock was selected before focusing the EventGraph then this item will be removed - more worse then doing nothing.

How to Reproduce?

  1. Inside a EventGraph create a node
  2. Select the node
  3. Press Ctrl+x >> Nothing happens

Godot full version

4.2.2

Orchestrator version

2.0.1

Additional information

No response
@dschiller dschiller added the kind/bug A bug or regression in expected behavior. label Aug 11, 2024
@Naros Naros added bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 labels Aug 11, 2024
@Naros Naros added this to the 2.2 milestone Aug 11, 2024
@dschiller dschiller changed the title Ctrl+x dows not work in EventGraph Ctrl+x does not work in EventGraph Aug 11, 2024
@Naros Naros added the requires/godot-change Requires a change to upstream Godot. label Aug 12, 2024
@Naros
Copy link
Member

Naros commented Aug 12, 2024

So it does not seem that Godot's standard GraphEdit reacts to the ui_cut action, so we probably should submit an upstream PR to add this to the GraphEdit base control, and meanwhile we can add a hook for this in our custom class until Godot adds it upstream.

@Naros
Copy link
Member

Naros commented Aug 16, 2024

Added upstream PR - godotengine/godot#95614

Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 16, 2024
@Naros
CraterCrashGH-714 Support ui_cut action in GraphEdit controls
92dadeb
@Naros Naros mentioned this issue Aug 16, 2024
Merged
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 18, 2024
@Naros
CraterCrashGH-714 Support ui_cut action in GraphEdit controls
1b17350
@Shadowblitz16 Shadowblitz16 mentioned this issue Aug 23, 2024
Closed
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 8, 2024
@Naros
CraterCrashGH-714 Support ui_cut action in GraphEdit controls
8c8c552
Naros added a commit that referenced this issue Sep 8, 2024
@Naros
GH-714 Support ui_cut action in GraphEdit controls
704cfba
@Naros Naros closed this as completed in #751 Sep 8, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 8, 2024
@Naros
CraterCrashGH-714 Support ui_cut action in GraphEdit controls
20dd5bf
Naros added a commit to Naros/godot-orchestrator that referenced this issue Sep 8, 2024
@Naros
CraterCrashGH-714 Support ui_cut action in GraphEdit controls
2c35abc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/bug A bug or regression in expected behavior. requires/godot-change Requires a change to upstream Godot.
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-714 Support ui_cut action in GraphEdit controls Naros/godot-orchestrator
2 participants
@dschiller @Naros