Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal goto_script_line causes editor to crash if script is not an Orchestration #687

Closed
Naros opened this issue Aug 9, 2024 · 0 comments · Fixed by #688
Closed

Signal goto_script_line causes editor to crash if script is not an Orchestration #687

Naros opened this issue Aug 9, 2024 · 0 comments · Fixed by #688
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Aug 9, 2024

Describe the bug

When clicking errors in the editor's Error panel, the new Godot Debugger support will cause the editor to crash because the goto_script_line signal doesn't check that the Ref<Script> is an orchestration before use.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.rc4

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Aug 9, 2024
@Naros Naros added this to the 2.1 milestone Aug 9, 2024
@Naros Naros changed the title Signal goto_script_line causes script if script is not an Orchestration Signal goto_script_line causes editor to crash if script is not an Orchestration Aug 9, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 9, 2024
@Naros
CraterCrashGH-687 Check script type on debugger signals
dcc6312
@Naros Naros mentioned this issue Aug 9, 2024
Merged
Naros added a commit that referenced this issue Aug 9, 2024
@Naros
GH-687 Check script type on debugger signals
44e310d
@Naros Naros closed this as completed in #688 Aug 9, 2024
Naros added a commit that referenced this issue Aug 9, 2024
@Naros
GH-687 Fix usage of script vs p_script
0b4de3a
Naros added a commit that referenced this issue Aug 9, 2024
@Naros
GH-687 Check script type on debugger signals
377fcc1
Naros added a commit that referenced this issue Aug 9, 2024
@Naros
GH-687 Fix usage of script vs p_script
bb506be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-687 Check script type on debugger signals Naros/godot-orchestrator
1 participant
@Naros