Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EditorInterface::get_singleton() instead of OrchestratorPlugin::get_singleton() references #655

Closed
Naros opened this issue Aug 3, 2024 · 0 comments · Fixed by #656
Closed

Use EditorInterface::get_singleton() instead of OrchestratorPlugin::get_singleton() references #655

Naros opened this issue Aug 3, 2024 · 0 comments · Fixed by #656
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/enhancement New feature or request
Milestone
2.2

Comments

@Naros
Copy link
Member

Naros commented Aug 3, 2024

Description

There are a number of places where our code traverses the OrchestratorPlugin to get the EditorInterface. This is unnecessary as the EditorInterface is exposed as a singleton.

Implementation ideas

No response
@Naros Naros added kind/enhancement New feature or request cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 labels Aug 3, 2024
@Naros Naros added this to the 2.2 milestone Aug 3, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 3, 2024
@Naros
CraterCrashGH-655 Use EditorInterface::get_singleton where possible
cad5fb2
@Naros Naros mentioned this issue Aug 3, 2024
Merged
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 15, 2024
@Naros
CraterCrashGH-655 Use EditorInterface::get_singleton where possible
b8a42ab
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 15, 2024
@Naros
CraterCrashGH-655 Use EditorInterface::get_singleton where possible
a9f4bd3
Naros added a commit that referenced this issue Aug 15, 2024
@Naros
GH-655 Use EditorInterface::get_singleton where possible
0333834
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 15, 2024
@Naros
CraterCrashGH-655 Use EditorInterface::get_singleton where possible
df9d648
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 15, 2024
@Naros
CraterCrashGH-655 Use EditorInterface::get_singleton where possible
a37e909
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 19, 2024
@Naros
CraterCrashGH-655 Use EditorInterface::get_singleton where possible
3a48f08
Naros added a commit to Naros/godot-orchestrator that referenced this issue Aug 19, 2024
@Naros
CraterCrashGH-655 Use EditorInterface::get_singleton where possible
2ba3b94
Naros added a commit that referenced this issue Aug 25, 2024
@Naros
GH-655 Use EditorInterface::get_singleton where possible
0fd2856
Naros added a commit that referenced this issue Aug 25, 2024
@Naros
GH-655 Use EditorInterface::get_singleton where possible
bc2fa06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 cherrypick:2.1 Requires cherry-pick to Orchestrator 2.1 kind/enhancement New feature or request
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

GH-655 Use EditorInterface::get_singleton where possible Naros/godot-orchestrator
1 participant
@Naros