Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding execution pins automatically to is_ or get_ prefixed script functions introduces backward incompatibility #622

Closed
Naros opened this issue Jul 29, 2024 · 0 comments · Fixed by #623
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone

Comments

@Naros
Copy link
Member

Naros commented Jul 29, 2024

Describe the bug

In #583, a change was added that allows the is_ and get_ user-defined functions always to render execution pins. The problem is that this introduces a backward incompatibility with existing Orchestrations, making them inoperable.

Expected behavior

Old orchestrations should continue to work.

Actual behavior

Old orchestrations that have is_ or get_ prefixed functions cease to work.

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

No response

Additional information

To make this backward compatible, we could add a flag to each OScriptNodeCallScriptFunction node that tracks whether to display the execution pins. By default when loading older orchestrations and the function name begins with is_ or get_, the flag would be set to false to remain backward compatible.

For newly added/placed nodes, the flag would be set to true for all script function calls.

Question: Should this flag be togglable in the inspector?

@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 29, 2024
@Naros Naros added this to the 2.1 milestone Jul 29, 2024
@Naros Naros added the blocker label Jul 29, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 29, 2024
Naros added a commit that referenced this issue Jul 29, 2024
Naros added a commit that referenced this issue Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant