Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric default value field does not coerce values #605

Closed
Naros opened this issue Jul 27, 2024 · 0 comments · Fixed by #606
Closed

Numeric default value field does not coerce values #605

Naros opened this issue Jul 27, 2024 · 0 comments · Fixed by #606
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 27, 2024

Describe the bug

When a numeric pin (int or float) accepts a value that does not conform to the int or float data type, while the value in the default value property is coerced, the UI is not properly coerced. For example, entering a value of abc should result in the field being set to 0. If the data type is int and entering a value of 25.25 should result in the field being set to 25.

Expected behavior

  1. Entering a value of abc should set the LineEdit value to 0.
  2. Entering a value of 25.25 should set the LineEdit value to 25 when the type is Int.

Actual behavior

The entered value is just retained without any field updates.

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.rc2

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 27, 2024
@Naros Naros added this to the 2.1 milestone Jul 27, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 28, 2024
@Naros
CraterCrashGH-605 Improve numeric default value widget validation
48af5cb
@Naros Naros mentioned this issue Jul 28, 2024
Merged
Naros added a commit that referenced this issue Jul 28, 2024
@Naros
GH-605 Improve numeric default value widget validation
3fefdbb
Naros added a commit that referenced this issue Jul 28, 2024
@Naros
GH-605 Improve numeric default value widget validation
b416fcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-605 Improve numeric default value widget validation Naros/godot-orchestrator
1 participant
@Naros