Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputAction pin does not auto-select first element #582

Closed
Naros opened this issue Jul 23, 2024 · 0 comments · Fixed by #586
Closed

InputAction pin does not auto-select first element #582

Naros opened this issue Jul 23, 2024 · 0 comments · Fixed by #586
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone

Comments

@Naros
Copy link
Member

Naros commented Jul 23, 2024

Describe the bug

Inside the OrchestratorGraphNodePinInputAction::_populate_action_list() method, if no item is selected, the pin's default value is assigned an empty variant, which can lead to a series of spammed errors about unable to locate an input action with an empty string.

Expected behavior

There should be some type of error or the item shown as being selected should be auto-selected.

Actual behavior

Runtime throws an error

How to Reproduce?

  1. Add an Input singleton to the graph.
  2. Drag away and select the Is Action Pressed function
  3. Save and run

Godot full version

4.3.beta3

Orchestrator version

2.1.rc2

Additional information

For 2.1, it would make sense for now to enforce auto-selection of the first action at index 0 when first placing the node. This aligns with what a user would initially expect, given there is no --Select-- type of placeholder option.

For 2.2, we should rethink this specific pin's validation routine. Ideally, it would be helpful to introduce a --Select-- placeholder and then throw an error during validation and runtime if the user never explicitly picked an action name. The main issue here, specifically with runtime validation, is how to know what member function calls require such extended validation or, more specifically, which function calls use this input action list of values since this is handled at the editor layer and not the underlying resource layer, we're currently limited.

@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 23, 2024
@Naros Naros added this to the 2.1 milestone Jul 23, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 24, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant