Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input action should report error if action name is empty #579

Closed
Naros opened this issue Jul 23, 2024 · 0 comments · Fixed by #580
Closed

Input action should report error if action name is empty #579

Naros opened this issue Jul 23, 2024 · 0 comments · Fixed by #580
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 23, 2024

Describe the bug

Presently the InputAction node does not throw an error if the user fails to provide an action name, and instead allows the script to continue running without raising a debugger breakpoint.

Expected behavior

A breakpoint should be raised with a sufficient error.

Actual behavior

No response

How to Reproduce?

No response

Godot full version

4.3.beta3

Orchestrator version

2.1.rc2

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 23, 2024
@Naros Naros added this to the 2.1 milestone Jul 23, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 23, 2024
@Naros
CraterCrashGH-579 Raise breakpoint when input action has no action name
9183e97
@Naros Naros mentioned this issue Jul 23, 2024
Merged
Naros added a commit that referenced this issue Jul 23, 2024
@Naros
GH-579 Raise breakpoint when input action has no action name
98fdb36
Naros added a commit that referenced this issue Jul 23, 2024
@Naros
GH-579 Raise breakpoint when input action has no action name
bf7d58a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-579 Raise breakpoint when input action has no action name Naros/godot-orchestrator
1 participant
@Naros