Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph function tab is not always closed #574

Closed
Naros opened this issue Jul 22, 2024 · 0 comments · Fixed by #585
Closed

Graph function tab is not always closed #574

Naros opened this issue Jul 22, 2024 · 0 comments · Fixed by #585
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 22, 2024

Describe the bug

When creating a new function without changing it's name, the function tab is not closed when the function is removed.

Expected behavior

Function tab, if opened, is closed when the function is removed.

Actual behavior

Function tab remains.

How to Reproduce?

  1. Create a new function by pressing the + icon.
  2. Click anywhere in the editor to force the edit function name operation to be canceled.
  3. Right-click the function entry and select Remove.
  4. The function graph tab remains visible while the function no longer exists.

Godot full version

4.3.beta3

Orchestrator version

2.1.rc2

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 22, 2024
@Naros Naros added this to the 2.1 milestone Jul 22, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 24, 2024
@Naros
CraterCrashGH-574 Strengthen validation for adding/renaming component…
7b1c271 
… items
@Naros Naros mentioned this issue Jul 24, 2024
Merged
Naros added a commit that referenced this issue Jul 25, 2024
@Naros
GH-574 Strengthen validation for adding/renaming component items
ebbdfff
Naros added a commit that referenced this issue Jul 25, 2024
@Naros
GH-574 Strengthen validation for adding/renaming component items
8227621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-574 Strengthen validation for adding/renaming component items Naros/godot-orchestrator
1 participant
@Naros