Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight metrics differently #1

Closed
wants to merge 1 commit into from
Closed

Weight metrics differently #1

wants to merge 1 commit into from

Conversation

francois-rozet
Copy link

@francois-rozet francois-rozet commented Jul 13, 2021

Hello 👋

In your implementation, each metric has the same weight in the score/rank. I feel like your number of commits (even though you are a complete outlier) should not be as strong of an indicator as the number of stars you received.

In this PR, I added the possibility to choose weights, but I've set them to 1., which makes it equivalent to your implementation.
You can choose them arbitrarily or we can discuss about it!

Also, I don't know how you've determined the average metrics but they seem wayyyyy off.
Especially, the number of stars, issues, PRs and followers are incredibly high. In my opinion the average user has like 13 stars from his 5 followers and never opens issues or prs.
Moreover, I think each commit is a contribution. Therefore average contributions are necessarily larger than average commits, and, in practice, nearly equal as it is the main way to contribute. I would in fact advocate to remove the commits count from the ranking and only use the contributions.

@francois-rozet
Copy link
Author

I've made my own pull request anuraghazra#1186 in the original repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant