Skip to content

Conversation

@AndreaWalchshoferSCCH
Copy link
Contributor

I am currently working on another name style rule, during which I noticed that any custom configuration of const_variable_name_style is not applied due to this missing line.

This PR resolves that problem.

@CppCXY
Copy link
Owner

CppCXY commented Jun 10, 2024

I noticed that you seem very interested in writing lints, but this library is not designed for that. It lacks many facilities, and due to design issues, debugging is very difficult. I suggest you consider re-implementing the naming style checks in my language server

@CppCXY CppCXY merged commit b11abfa into CppCXY:master Jun 10, 2024
@AndreaWalchshoferSCCH
Copy link
Contributor Author

Thanks for merging!
And also thank you for pointing out your language server, I will definitely keep an eye on that from now on.

However, I'm using the LuaLS within a work project where it is currently established and started writing lints for the LuaLS project to cover missing requirements. For lints concerning name style, I was rightfully redirected to your EmmyLuaCodeStyle project so I continued implementing the appropriate lints/formatting options we were missing here.

I would still go forward with contributing that work-in-progress name style here. It is the last necessary change I know of right now so I got it covered within the current LuaLS versions. Because it seems that your language server is still in early stages.

@AndreaWalchshoferSCCH AndreaWalchshoferSCCH deleted the awa/const-namestyle-configuration branch June 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants