fix: 🚸 recognize empty string as valid seedValue

CourtHive · Jun 3, 2024 · 4529d0f · 4529d0f
1 parent 6e82e7e
commit 4529d0f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/components/renderSeeding.js b/src/components/renderSeeding.js
@@ -1,16 +1,16 @@
 export function renderSeeding({ className, composition, side }) {
-  const seedValue = side?.seedValue || side?.seedNumber;
+  const seedValue = side?.seedValue !== undefined ? side.seedValue : side?.seedNumber;
 
-  if (!seedValue) return "";
+  if (!seedValue) return '';
 
   const configuration = composition?.configuration || {};
   const { bracketedSeeds } = configuration;
 
-  const brackets = (typeof bracketedSeeds === "boolean" && ["(", ")"]) ||
-    (bracketedSeeds === "square" && ["[", "]"]) || ["", ""];
+  const brackets = (typeof bracketedSeeds === 'boolean' && ['(', ')']) ||
+    (bracketedSeeds === 'square' && ['[', ']']) || ['', ''];
   const seedDisplay = `${brackets[0]}${seedValue}${brackets[1]}`;
 
-  const element = configuration.seedingElement === "sup" ? "sup" : "span";
+  const element = configuration.seedingElement === 'sup' ? 'sup' : 'span';
   const sup = document.createElement(element);
   sup.className = className;
   sup.innerHTML = seedDisplay;

diff --git a/src/stories/structure.stories.js b/src/stories/structure.stories.js
@@ -23,8 +23,8 @@ const eventHandlers = {
     const composition = {
       configuration: {
         bracketedSeeds: 'square',
-        flags: true,
-        showAddress: true
+        showAddress: true,
+        flags: true
       }
     };
     const participants = matchUp.sides.map(({ participant }) => participant);