feat: [SER-2215] Adding disable feature to dialog box buttons #5925
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
82
to
87
| isButtonDisabled: function() { | ||
| return { | ||
| save: this.saveButtonDisabled, | ||
| cancel: this.cancelButtonDisabled | ||
| }; | ||
| }, |
There was a problem hiding this comment.
Why do you converted both props into a object?
In my opinion, this can lead to errors in the future, because when seeing isButtonDisabled the developer may expect a boolean and in reality is getting an object.
I suggest using the props directly and removing this
Comment on lines
88
to
91
| buttonStyle: function() { | ||
| return function(disabled) { | ||
| return disabled ? { opacity: 0.5 } : {}; | ||
| }; |
There was a problem hiding this comment.
You are using a computed property to return a method, this is bad practice.
It should be moved to methods, for example:
getButtonStyle: function(disabled) {
return disabled ? { opacity: 0.5 } : {};
}
gabrieloliveirapinto
approved these changes
Jan 20, 2025
gabrieloliveirapinto
merged commit 2198bf1
into
journey+content-main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.