DA-1203 Modified Add Slow Running Queries tools #74

AayushTyagi1 · 2025-11-11T08:21:50Z

Screen.Recording.2025-11-11.at.2.02.48.PM.mov

gemini-code-assist · 2025-11-11T08:22:05Z

Summary of Changes

Hello @AayushTyagi1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive set of new query analysis tools designed to help identify and diagnose performance issues within the system. By leveraging the system:completed_requests catalog, these tools provide detailed insights into query behavior, including execution times, frequency, result sizes, and index usage patterns. This enhancement aims to empower developers and administrators with better capabilities for optimizing database performance and pinpointing inefficient queries.

Highlights

New Query Analysis Tools: A comprehensive suite of new functions has been added to identify and analyze various aspects of query performance and efficiency.
Performance Insight: These tools provide detailed insights into longest-running queries, most frequent queries, queries with large result sets, and different types of index utilization (primary, covering, selectivity).
Expanded Toolset: The src/tools module now exposes these new query analysis capabilities, making them accessible for broader use within the system.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copilot

Pull Request Overview

This PR adds multiple query analysis tools to diagnose slow-running and inefficient queries by leveraging the system:completed_requests catalog. The change also removes a comment that was preventing the exposure of run_cluster_query to the MCP server.

Key changes:

Exposed run_cluster_query function by removing restriction comment
Added seven new query analysis functions for performance diagnostics
Updated exports in __init__.py to include all new query analysis tools

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/tools/query.py	Removed comment blocking `run_cluster_query` exposure; added seven query analysis functions for identifying slow, frequent, large-response, primary-index-using, non-covering-index, and non-selective queries
src/tools/init.py	Added imports and exports for all seven new query analysis functions to make them available as tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/tools/query.py

gemini-code-assist

Code Review

This pull request introduces a suite of new tools for analyzing query performance by querying the system:completed_requests catalog. The changes are well-structured, adding new functions in src/tools/query.py and exposing them through src/tools/__init__.py.

My review focuses on several key areas:

Security: I've identified multiple instances of potential SQL injection vulnerabilities due to the use of f-strings for constructing queries with user-provided parameters. I've provided suggestions to use parameterized queries, which is a critical security best practice.
Correctness & Consistency: Some of the new query functions have inconsistent filtering logic compared to others. I've suggested changes to align them, ensuring they all exclude system-level queries for more focused and relevant results.
Maintainability: I've also pointed out a minor style issue in __init__.py regarding the sorting of tool lists, which will improve code readability and long-term maintenance.

Overall, these are valuable additions for monitoring database performance. Addressing the feedback will make the new tools more secure, robust, and maintainable.

src/tools/query.py

src/tools/__init__.py

gemini-code-assist · 2025-11-11T08:23:54Z

src/tools/query.py

+    WHERE phaseCounts.`primaryScan` IS NOT MISSING
+        AND UPPER(statement) NOT LIKE '% SYSTEM:%'


For consistency with other query-analyzing tools in this file, consider filtering out INFER and CREATE INDEX statements. This will help focus the results on application-level queries.

Suggested change

WHERE phaseCounts.`primaryScan` IS NOT MISSING

AND UPPER(statement) NOT LIKE '% SYSTEM:%'

WHERE phaseCounts.`primaryScan` IS NOT MISSING

AND UPPER(statement) NOT LIKE 'INFER %'

AND UPPER(statement) NOT LIKE 'CREATE INDEX%'

AND UPPER(statement) NOT LIKE '% SYSTEM:%'

If you are adding INFER and SYSTEM, might as well add explain and advise as well- for consistency

gemini-code-assist · 2025-11-11T08:23:54Z

src/tools/query.py

+    WHERE phaseCounts.`indexScan` IS NOT MISSING
+        AND phaseCounts.`fetch` IS NOT MISSING
+        AND UPPER(statement) NOT LIKE '% SYSTEM:%'


This query is missing filters for INFER and CREATE INDEX statements, which are present in other similar functions. Adding them would provide more consistent and focused results on application queries.

Suggested change

WHERE phaseCounts.`indexScan` IS NOT MISSING

AND phaseCounts.`fetch` IS NOT MISSING

AND UPPER(statement) NOT LIKE '% SYSTEM:%'

WHERE phaseCounts.`indexScan` IS NOT MISSING

AND phaseCounts.`fetch` IS NOT MISSING

AND UPPER(statement) NOT LIKE 'INFER %'

AND UPPER(statement) NOT LIKE 'CREATE INDEX%'

AND UPPER(statement) NOT LIKE '% SYSTEM:%'

gemini-code-assist · 2025-11-11T08:23:54Z

src/tools/query.py

+    SELECT statement,
+       AVG(phaseCounts.`indexScan` - resultCount) AS diff
+    FROM system:completed_requests
+    WHERE phaseCounts.`indexScan` > resultCount


This query is missing filters to exclude system-level statements (like INFER, CREATE INDEX, and queries on SYSTEM: keyspaces). Including these filters, as done in other functions in this file, will help to focus on application performance issues.

Suggested change

WHERE phaseCounts.`indexScan` > resultCount

WHERE phaseCounts.`indexScan` > resultCount

AND UPPER(statement) NOT LIKE 'INFER %'

AND UPPER(statement) NOT LIKE 'CREATE INDEX%'

AND UPPER(statement) NOT LIKE '% SYSTEM:%'

kaminijagtiani · 2025-11-25T22:21:40Z

src/tools/query.py

+    SELECT statement,
+        COUNT(1) AS queries
+    FROM system:completed_requests
+    WHERE UPPER(statement) NOT LIKE 'INFER %'


For every query that we run via UI, we also run explain and advise on it.
So you might also need to filter out explain and advise for top most frequent queries

kaminijagtiani

For every query that we run via UI, we also run explain and advise on it.
So you might also need to filter out explain and advise for top most frequent queries.
And if for consistency you are filtering out infer, create index for all queries- filter out explain and advise as well

AayushTyagi1 · 2025-12-03T07:18:44Z

Resolve Comments. Ready to review @nithishr

nithishr

Looks good. Some minor nits & we can merge it

src/tools/query.py

DOCKER.md

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/tools/__init__.py

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/tools/query.py

DOCKER.md

Co-authored-by: Copilot <[email protected]>

DA-1203 Modified Add Slow Running Queries tools

4a25f18

AayushTyagi1 requested a review from Copilot November 11, 2025 08:21

Copilot AI reviewed Nov 11, 2025

View reviewed changes

src/tools/query.py Show resolved Hide resolved

src/tools/query.py Outdated Show resolved Hide resolved

gemini-code-assist bot reviewed Nov 11, 2025

View reviewed changes

SQL Injection Issue fixed

aa864e2

AayushTyagi1 requested a review from nithishr November 11, 2025 08:49

kaminijagtiani reviewed Nov 25, 2025

View reviewed changes

kaminijagtiani approved these changes Nov 25, 2025

View reviewed changes

AayushTyagi1 added 3 commits December 1, 2025 19:05

DA-1363: Modified Empty Query Settled

0a8a962

DA-1203 Filter out queries to filter primary and explain

6972b64

Merge branch 'main' into DA-1203-identify-slow-running-queries-tools

aca35a6

nithishr mentioned this pull request Dec 4, 2025

DA-1203 identify slow running queries tools 2 #84

Closed

DA-1203: Updated: Readme and Dockermd with new toold

adea7b7

nithishr reviewed Dec 8, 2025

View reviewed changes

Review fixed

029a7a9

AayushTyagi1 requested review from Copilot and nithishr December 8, 2025 14:56

Copilot AI reviewed Dec 8, 2025

View reviewed changes

src/tools/__init__.py Outdated Show resolved Hide resolved

src/tools/__init__.py Outdated Show resolved Hide resolved

src/tools/__init__.py Outdated Show resolved Hide resolved

Review fixed

6c62c62

AayushTyagi1 requested a review from Copilot December 8, 2025 15:06

Copilot AI reviewed Dec 8, 2025

View reviewed changes

src/tools/query.py Outdated Show resolved Hide resolved

DOCKER.md Outdated Show resolved Hide resolved

AayushTyagi1 and others added 2 commits December 8, 2025 20:39

Update DOCKER.md

cf65885

Co-authored-by: Copilot <[email protected]>

Update src/tools/query.py

1a2b288

Co-authored-by: Copilot <[email protected]>

nithishr approved these changes Dec 8, 2025

View reviewed changes

AayushTyagi1 merged commit f599b5f into main Dec 8, 2025
6 checks passed

nithishr mentioned this pull request Dec 10, 2025

Slow queries retrieval #22

Closed

		WHERE phaseCounts.`primaryScan` IS NOT MISSING
		AND UPPER(statement) NOT LIKE '% SYSTEM:%'

DA-1203 Modified Add Slow Running Queries tools #74

DA-1203 Modified Add Slow Running Queries tools #74

Uh oh!

Conversation

AayushTyagi1 commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Nov 11, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

kaminijagtiani Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

kaminijagtiani Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaminijagtiani left a comment

Choose a reason for hiding this comment

Uh oh!

AayushTyagi1 commented Dec 3, 2025

Uh oh!

nithishr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

AayushTyagi1 commented Nov 11, 2025 •

edited

Loading

kaminijagtiani Nov 25, 2025 •

edited

Loading