This repository has been archived by the owner on Sep 17, 2023. It is now read-only.
implement settings screen #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheRemakerMan <[email protected]> Signed-off-by: TheRemakerMan <[email protected]>
Bumps [org.jetbrains.kotlin.android](https://github.com/JetBrains/kotlin) from 1.8.0 to 1.8.20. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.8.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.8.0...v1.8.20) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.jetbrains.kotlin:kotlin-reflect](https://github.com/JetBrains/kotlin) from 1.8.10 to 1.8.20. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.8.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.8.10...v1.8.20) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-reflect dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.squareup:kotlinpoet](https://github.com/square/kotlinpoet) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/square/kotlinpoet/releases) - [Changelog](https://github.com/square/kotlinpoet/blob/master/docs/changelog.md) - [Commits](square/kotlinpoet@1.12.0...1.13.0) --- updated-dependencies: - dependency-name: com.squareup:kotlinpoet dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.jetbrains.kotlinx:kotlinx-coroutines-android](https://github.com/Kotlin/kotlinx.coroutines) from 1.6.1 to 1.6.4. - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.6.1...1.6.4) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.jetbrains.kotlin:kotlin-scripting-compiler](https://github.com/JetBrains/kotlin) from 1.8.10 to 1.8.20. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.8.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.8.10...v1.8.20) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-scripting-compiler dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: TheRemakerMan <[email protected]>
Signed-off-by: TheRemakerMan <[email protected]>
Signed-off-by: TheRemakerMan <[email protected]>
Signed-off-by: TheRemakerMan <[email protected]>
Signed-off-by: TheRemakerMan <[email protected]>
…erences Signed-off-by: TheRemakerMan <[email protected]>
… summary Signed-off-by: TheRemakerMan <[email protected]>
| @@ -24,6 +24,6 @@ fun CodeEditor.setLanguageTheme(language: EditorLanguage) { | |||
| * Sets the font and enables highlighting of the current line for the code editor. | |||
| */ | |||
| fun CodeEditor.setFont() { | |||
| typefaceText = ResourcesCompat.getCachedFont(context, R.font.noto_sans_mono) | |||
| typefaceText = ResourcesCompat.getFont(context, R.font.noto_sans_mono) | |||
There was a problem hiding this comment.
getCachedFont would be better here i think
There was a problem hiding this comment.
With the getCachedFont method, the font will not be loaded since it is not cached.
There was a problem hiding this comment.
It checks if its cached and sets it. atleast in emulator, it loads properly
There was a problem hiding this comment.
Have you tested on a real device? When using the getCachedFont() method on my device, the font simply didn't load.
There was a problem hiding this comment.
Check last artifact (not pr's artifact)
| <resources> | ||
| <string-array name="java_version_entries"> | ||
| <item>8</item> | ||
| <item>11</item> |
There was a problem hiding this comment.
what about other version? For ex if you just want to use text blocks and want compatibility with Java 16, you can just use it
There was a problem hiding this comment.
okay, i will add every java version from 8 to 17.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added prefs object class.