fix: mitigate hyper error: IncompleteMessage: connection closed before message completed #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manuthor
force-pushed
the
more_certs_validate_hyper
branch
2 times, most recently
from
d945902
to
ab79673
Compare
Manuthor
force-pushed
the
more_certs_validate_hyper
branch
from
ab79673
to
ac8884b
Compare
Manuthor
force-pushed
the
more_certs_validate_hyper
branch
from
5430a0a
to
a72189c
Compare
Manuthor
added a commit
that referenced
this pull request
Aug 10, 2024
…e message completed (#285) * fix: try fix hyper problem * chore: log kms rest client error * chore: log kms rest client error * fix: re-add small delay after a hyper incompletemessage error * fix: revert test cli changes * fix: revert test_server change * fix: small fix in certificate indexing * fix: try new timeout on reqwest * fix: control RUST_LOG from variable env. * chore: force sleep before retry * fix: use default features of reqwest * fix: sync reqwest features between client and server * chore: bump reqwest to 0.12 * fix: set default timeout on server. Remove delay in fetching CRL * fix: try to block async thread on client request * fix: keep retry on failure on KMS rest client
Manuthor
added a commit
that referenced
this pull request
Aug 13, 2024
* fix: pedantic clippy lints * fix: validate certificate generation * fix: try disable hyper idle pool * fix: add retry on KMS rest client * fix: mitigate hyper error: IncompleteMessage: connection closed before message completed (#285) * fix: try fix hyper problem * chore: log kms rest client error * chore: log kms rest client error * fix: re-add small delay after a hyper incompletemessage error * fix: revert test cli changes * fix: revert test_server change * fix: small fix in certificate indexing * fix: try new timeout on reqwest * fix: control RUST_LOG from variable env. * chore: force sleep before retry * fix: use default features of reqwest * fix: sync reqwest features between client and server * chore: bump reqwest to 0.12 * fix: set default timeout on server. Remove delay in fetching CRL * fix: try to block async thread on client request * fix: keep retry on failure on KMS rest client * ci: fix tests on certificate validation * chore: revert CI change, remove filter on tests certify * test: connection pool * chore: use std::RwLock instead of tokio::RwLock * chore: bump sqlx version * chore: remove http crate and reuse actix-web:http crate * chore: ignore temporarly 2 tests on server * test: set max idle connection on validate operation * test: remove RwLock on client * test: use rustls-tls for server * chore: downgrade hyper-util to 0.1.5 * test: disabling cert auth in test_server * fix: remove logs in test - not required for now * chore: revert downgrade of hyper-util + remove useless join_all * docs: add doc validation * fix: cargo format * ci: re-enable logs in tests * chore: reduce deps in Cargo.lock * chore: small clippy fixes * docs: add doc validation * fix: simplify pieces of code * fix: avoid clones * fix: more clippy fixes * chore: rename certificates sorting function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Validate KMIP operation requires to fetch CRLs (potentially on external websites), there is a racy problem in KMS CLI tests.
There is a hyper known issue where hyper selects a dead connection from its pool: hyperium/hyper#2136.
The bug is hard to reproduce and happens randomly and almost exclusively in Github CI (network bandwith limitation?).
The KMS Rest Client retry once in case of error after a small arbitrary delay (required for pool connection availability).