Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ibc app version from middleware #1102

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 21, 2022

After #1088
This looks better now

@alpe alpe changed the base branch from main to 960_ibc420 November 21, 2022 10:28
@alpe alpe requested a review from ethanfrey November 21, 2022 10:30
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #1102 (45cc085) into 960_ibc420 (2ce07c9) will decrease coverage by 0.07%.
The diff coverage is 61.90%.

Impacted file tree graph

@@              Coverage Diff               @@
##           960_ibc420    #1102      +/-   ##
==============================================
- Coverage       59.87%   59.80%   -0.08%     
==============================================
  Files              54       54              
  Lines            7299     7306       +7     
==============================================
- Hits             4370     4369       -1     
- Misses           2617     2621       +4     
- Partials          312      316       +4     
Impacted Files Coverage Δ
x/wasm/ibc.go 67.41% <60.00%> (-2.18%) ⬇️
app/app.go 88.54% <100.00%> (ø)
x/wasm/keeper/keeper.go 87.40% <0.00%> (-0.32%) ⬇️

@alpe alpe requested a review from pinosu November 21, 2022 12:17
@alpe alpe merged commit 48642be into 960_ibc420 Nov 22, 2022
@alpe alpe deleted the 960_ibc420_app_version branch November 22, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants