Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cosmwasm-storage dependency #827

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Remove cosmwasm-storage dependency #827

merged 4 commits into from
Oct 12, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Oct 12, 2022 •
edited
Loading

cosmwasm-storage is going to be deprecated. This is preparation for that.

All these helpers added to multi-test have been copy-pasted from cosmwasm-storage.

webmaster128
webmaster128 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I think as part of this change you can also delete packages/storage-plus/src/legacy_helpers.rs which is an unused module.

@uint uint merged commit 1e534bd into main Oct 12, 2022
@uint uint deleted the remove-cosmwasm-storage-dependency branch October 12, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uint @webmaster128