Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deny_unknown_fields and combine all query responses in one file #722

Closed
wants to merge 2 commits into from

Conversation

ethanfrey
Copy link
Member

This is for testing formats that play well with ts codeine tooling.

@pyramation this is for you

@pyramation
Copy link

https://gist.github.com/pyramation/5eab090a565e95c5e143f419337b0e6d

How does this look?

@ethanfrey
Copy link
Member Author

https://gist.github.com/pyramation/5eab090a565e95c5e143f419337b0e6d

How does this look?

Very nice. Cleaner without the additional properties

Strictly speaking QueryResponse doesn't need to be exposed. The main item is that it helps you find the return types without relying on naming convertions.

@ethanfrey
Copy link
Member Author

d1b336c is an approach to combine it all into one file, which will make for much easier distribution

@ethanfrey
Copy link
Member Author

Not small, but not as big as I feared, especially if stored gzipped.

% ls -l schema 
-rw-r--r-- 1 ethanfrey staff 10625 May 16 22:20 api.json
-rw-r--r-- 1 ethanfrey staff  1327 May 16 22:20 api.json.gz

@ethanfrey
Copy link
Member Author

IIRC, another request was returning some information on the Events that are returned from the different messages that can be executed?

That would definitely be a different task, but good to gather a Wishlist.

Anything else I should have in mind

@pyramation
Copy link

Ok, I just added a packed option, not sure if that's the best name, but I got d1b336c to work

CosmWasm/ts-codegen@7446f19

I've added the CW4Group as a fixture so we can continue to improve in testing

@pyramation
Copy link

pyramation commented May 16, 2022

Regarding certain messages that we want to remove, happy to adapt the library. I think some of the {Message}Response are autogenerated as a naming convention.

let's definitely get a wish list going! We can also start making issues in the repo

@ueco-jb
Copy link
Contributor

ueco-jb commented Jul 8, 2022

@ethanfrey I think this one can be closed, since follow up is in progress?

@pyramation
Copy link

yea @ueco-jb I think you can this work is all being done here CosmWasm/cosmwasm#1339 by @uint

@ueco-jb ueco-jb closed this Jul 8, 2022
@ueco-jb ueco-jb deleted the experiments-with-json-schema branch August 30, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants