Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup multitest #324

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Cleanup multitest #324

merged 4 commits into from
Jul 13, 2021

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jul 12, 2021 •
edited
Loading

Start work on #259

  • Full support for Response type with Events (and SubMsg info)
  • Clean up naming (handle -> execute, init -> instantiate)

@ethanfrey ethanfrey requested a review from maurolacy July 12, 2021 17:28
maurolacy
maurolacy approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'm not so familiar with the events vs. attrs, and messages vs. submessages stuff yet, though.

packages/multi-test/src/app.rs Show resolved Hide resolved
@ethanfrey ethanfrey merged commit 551e793 into main Jul 13, 2021
@ethanfrey ethanfrey deleted the cleanup-multitest branch July 13, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanfrey @maurolacy