Skip to content

Commit

Permalink
rename KV -> Pair
Browse files Browse the repository at this point in the history
  • Loading branch information
yihuang committed Apr 2, 2021
1 parent 8e72a53 commit 137f326
Show file tree
Hide file tree
Showing 9 changed files with 46 additions and 46 deletions.
6 changes: 3 additions & 3 deletions contracts/cw1155-base/src/contract.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use cosmwasm_std::{
to_binary, Api, Binary, Deps, DepsMut, Env, HumanAddr, MessageInfo, Order, Response, StdResult,
Uint128, KV,
to_binary, Api, Binary, Deps, DepsMut, Env, HumanAddr, MessageInfo, Order, Pair, Response,
StdResult, Uint128,
};
use cw_storage_plus::Bound;

Expand Down Expand Up @@ -459,7 +459,7 @@ pub fn query(deps: Deps, env: Env, msg: Cw1155QueryMsg) -> StdResult<Binary> {
}
}

fn parse_approval(api: &dyn Api, item: StdResult<KV<Expiration>>) -> StdResult<cw1155::Approval> {
fn parse_approval(api: &dyn Api, item: StdResult<Pair<Expiration>>) -> StdResult<cw1155::Approval> {
item.and_then(|(k, expires)| {
let spender = api.human_address(&k.into())?;
Ok(cw1155::Approval { spender, expires })
Expand Down
4 changes: 2 additions & 2 deletions contracts/cw721-base/src/contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
use cosmwasm_std::entry_point;
use cosmwasm_std::{
attr, to_binary, Api, Binary, BlockInfo, Deps, DepsMut, Env, HumanAddr, MessageInfo, Order,
Response, StdError, StdResult, KV,
Pair, Response, StdError, StdResult,
};

use cw0::maybe_canonical;
Expand Down Expand Up @@ -497,7 +497,7 @@ fn query_all_approvals(
Ok(ApprovedForAllResponse { operators: res? })
}

fn parse_approval(api: &dyn Api, item: StdResult<KV<Expiration>>) -> StdResult<cw721::Approval> {
fn parse_approval(api: &dyn Api, item: StdResult<Pair<Expiration>>) -> StdResult<cw721::Approval> {
item.and_then(|(k, expires)| {
let spender = api.human_address(&k.into())?;
Ok(cw721::Approval { spender, expires })
Expand Down
40 changes: 20 additions & 20 deletions packages/multi-test/src/transactions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use std::ops::{Bound, RangeBounds};

use cosmwasm_std::Storage;
#[cfg(feature = "iterator")]
use cosmwasm_std::{Order, KV};
use cosmwasm_std::{Order, Pair};

#[cfg(feature = "iterator")]
/// The BTreeMap specific key-value pair reference type, as returned by BTreeMap<Vec<u8>, T>::range.
Expand Down Expand Up @@ -79,7 +79,7 @@ impl<'a> Storage for StorageTransaction<'a> {
start: Option<&[u8]>,
end: Option<&[u8]>,
order: Order,
) -> Box<dyn Iterator<Item = KV> + 'b> {
) -> Box<dyn Iterator<Item = Pair> + 'b> {
let bounds = range_bounds(start, end);

// BTreeMap.range panics if range is start > end.
Expand Down Expand Up @@ -172,7 +172,7 @@ enum Delta {
struct MergeOverlay<'a, L, R>
where
L: Iterator<Item = BTreeMapPairRef<'a, Delta>>,
R: Iterator<Item = KV>,
R: Iterator<Item = Pair>,
{
left: Peekable<L>,
right: Peekable<R>,
Expand All @@ -183,7 +183,7 @@ where
impl<'a, L, R> MergeOverlay<'a, L, R>
where
L: Iterator<Item = BTreeMapPairRef<'a, Delta>>,
R: Iterator<Item = KV>,
R: Iterator<Item = Pair>,
{
fn new(left: L, right: R, order: Order) -> Self {
MergeOverlay {
Expand All @@ -193,7 +193,7 @@ where
}
}

fn pick_match(&mut self, lkey: Vec<u8>, rkey: Vec<u8>) -> Option<KV> {
fn pick_match(&mut self, lkey: Vec<u8>, rkey: Vec<u8>) -> Option<Pair> {
// compare keys - result is such that Ordering::Less => return left side
let order = match self.order {
Order::Ascending => lkey.cmp(&rkey),
Expand All @@ -213,7 +213,7 @@ where
}

/// take_left must only be called when we know self.left.next() will return Some
fn take_left(&mut self) -> Option<KV> {
fn take_left(&mut self) -> Option<Pair> {
let (lkey, lval) = self.left.next().unwrap();
match lval {
Delta::Set { value } => Some((lkey.clone(), value.clone())),
Expand All @@ -226,9 +226,9 @@ where
impl<'a, L, R> Iterator for MergeOverlay<'a, L, R>
where
L: Iterator<Item = BTreeMapPairRef<'a, Delta>>,
R: Iterator<Item = KV>,
R: Iterator<Item = Pair>,
{
type Item = KV;
type Item = Pair;

fn next(&mut self) -> Option<Self::Item> {
let (left, right) = (self.left.peek(), self.right.peek());
Expand Down Expand Up @@ -352,7 +352,7 @@ mod test {
// unbounded
{
let iter = store.range(None, None, Order::Ascending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(
elements,
vec![
Expand All @@ -366,7 +366,7 @@ mod test {
// unbounded (descending)
{
let iter = store.range(None, None, Order::Descending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(
elements,
vec![
Expand All @@ -380,14 +380,14 @@ mod test {
// bounded
{
let iter = store.range(Some(b"f"), Some(b"n"), Order::Ascending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(elements, vec![(b"foo".to_vec(), b"bar".to_vec())]);
}

// bounded (descending)
{
let iter = store.range(Some(b"air"), Some(b"loop"), Order::Descending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(
elements,
vec![
Expand All @@ -400,35 +400,35 @@ mod test {
// bounded empty [a, a)
{
let iter = store.range(Some(b"foo"), Some(b"foo"), Order::Ascending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(elements, vec![]);
}

// bounded empty [a, a) (descending)
{
let iter = store.range(Some(b"foo"), Some(b"foo"), Order::Descending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(elements, vec![]);
}

// bounded empty [a, b) with b < a
{
let iter = store.range(Some(b"z"), Some(b"a"), Order::Ascending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(elements, vec![]);
}

// bounded empty [a, b) with b < a (descending)
{
let iter = store.range(Some(b"z"), Some(b"a"), Order::Descending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(elements, vec![]);
}

// right unbounded
{
let iter = store.range(Some(b"f"), None, Order::Ascending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(
elements,
vec![
Expand All @@ -441,7 +441,7 @@ mod test {
// right unbounded (descending)
{
let iter = store.range(Some(b"f"), None, Order::Descending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(
elements,
vec![
Expand All @@ -454,14 +454,14 @@ mod test {
// left unbounded
{
let iter = store.range(None, Some(b"f"), Order::Ascending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(elements, vec![(b"ant".to_vec(), b"hill".to_vec()),]);
}

// left unbounded (descending)
{
let iter = store.range(None, Some(b"no"), Order::Descending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(
elements,
vec![
Expand Down
2 changes: 1 addition & 1 deletion packages/storage-plus/src/indexed_map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ where
min: Option<Bound>,
max: Option<Bound>,
order: cosmwasm_std::Order,
) -> Box<dyn Iterator<Item = StdResult<cosmwasm_std::KV<T>>> + 'c>
) -> Box<dyn Iterator<Item = StdResult<cosmwasm_std::Pair<T>>> + 'c>
where
T: 'c,
{
Expand Down
16 changes: 8 additions & 8 deletions packages/storage-plus/src/indexes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
use serde::de::DeserializeOwned;
use serde::{Deserialize, Serialize};

use cosmwasm_std::{from_slice, Binary, Order, StdError, StdResult, Storage, KV};
use cosmwasm_std::{from_slice, Binary, Order, Pair, StdError, StdResult, Storage};

use crate::helpers::namespaces_with_key;
use crate::keys::EmptyPrefix;
Expand Down Expand Up @@ -77,8 +77,8 @@ where
fn deserialize_multi_kv<T: DeserializeOwned>(
store: &dyn Storage,
pk_namespace: &[u8],
kv: KV,
) -> StdResult<KV<T>> {
kv: Pair,
) -> StdResult<Pair<T>> {
let (key, pk_len) = kv;

// Deserialize pk_len
Expand Down Expand Up @@ -175,7 +175,7 @@ where
&self,
store: &'c dyn Storage,
prefix: K::Prefix,
) -> StdResult<Vec<KV<T>>> {
) -> StdResult<Vec<Pair<T>>> {
self.prefix(prefix)
.range(store, None, None, Order::Ascending)
.collect()
Expand All @@ -197,7 +197,7 @@ where
min: Option<Bound>,
max: Option<Bound>,
order: Order,
) -> Box<dyn Iterator<Item = StdResult<KV<T>>> + 'c>
) -> Box<dyn Iterator<Item = StdResult<Pair<T>>> + 'c>
where
T: 'c,
{
Expand Down Expand Up @@ -259,7 +259,7 @@ where
}
}

fn deserialize_unique_kv<T: DeserializeOwned>(kv: KV) -> StdResult<KV<T>> {
fn deserialize_unique_kv<T: DeserializeOwned>(kv: Pair) -> StdResult<Pair<T>> {
let (_, v) = kv;
let t = from_slice::<UniqueRef<T>>(&v)?;
Ok((t.pk.into(), t.value))
Expand All @@ -283,7 +283,7 @@ where
}

/// returns all items that match this secondary index, always by pk Ascending
pub fn item(&self, store: &dyn Storage, idx: K) -> StdResult<Option<KV<T>>> {
pub fn item(&self, store: &dyn Storage, idx: K) -> StdResult<Option<Pair<T>>> {
let data = self
.idx_map
.may_load(store, idx)?
Expand All @@ -307,7 +307,7 @@ where
min: Option<Bound>,
max: Option<Bound>,
order: Order,
) -> Box<dyn Iterator<Item = StdResult<KV<T>>> + 'c>
) -> Box<dyn Iterator<Item = StdResult<Pair<T>>> + 'c>
where
T: 'c,
{
Expand Down
12 changes: 6 additions & 6 deletions packages/storage-plus/src/iter_helpers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

use serde::de::DeserializeOwned;

use cosmwasm_std::KV;
use cosmwasm_std::Pair;
use cosmwasm_std::{from_slice, StdResult};

use crate::helpers::encode_length;

pub(crate) fn deserialize_kv<T: DeserializeOwned>(kv: KV) -> StdResult<KV<T>> {
pub(crate) fn deserialize_kv<T: DeserializeOwned>(kv: Pair) -> StdResult<Pair<T>> {
let (k, v) = kv;
let t = from_slice::<T>(&v)?;
Ok((k, t))
Expand Down Expand Up @@ -146,7 +146,7 @@ mod namespace_test {

// ensure we get proper result from prefixed_range iterator
let iter = range_with_prefix(&storage, &prefix, None, None, Order::Descending);
let elements: Vec<KV> = iter.collect();
let elements: Vec<Pair> = iter.collect();
assert_eq!(
elements,
vec![
Expand All @@ -171,14 +171,14 @@ mod namespace_test {
set_with_prefix(&mut storage, &other_prefix, b"moon", b"buggy");

// make sure start and end are applied properly
let res: Vec<KV> =
let res: Vec<Pair> =
range_with_prefix(&storage, &prefix, Some(b"b"), Some(b"c"), Order::Ascending)
.collect();
assert_eq!(res.len(), 1);
assert_eq!(res[0], (b"bar".to_vec(), b"none".to_vec()));

// make sure start and end are applied properly
let res: Vec<KV> = range_with_prefix(
let res: Vec<Pair> = range_with_prefix(
&storage,
&prefix,
Some(b"bas"),
Expand All @@ -188,7 +188,7 @@ mod namespace_test {
.collect();
assert_eq!(res.len(), 0);

let res: Vec<KV> =
let res: Vec<Pair> =
range_with_prefix(&storage, &prefix, Some(b"ant"), None, Order::Ascending).collect();
assert_eq!(res.len(), 2);
assert_eq!(res[0], (b"bar".to_vec(), b"none".to_vec()));
Expand Down
2 changes: 1 addition & 1 deletion packages/storage-plus/src/map.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ where
min: Option<Bound>,
max: Option<Bound>,
order: cosmwasm_std::Order,
) -> Box<dyn Iterator<Item = StdResult<cosmwasm_std::KV<T>>> + 'c>
) -> Box<dyn Iterator<Item = StdResult<cosmwasm_std::Pair<T>>> + 'c>
where
T: 'c,
{
Expand Down
8 changes: 4 additions & 4 deletions packages/storage-plus/src/prefix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use serde::de::DeserializeOwned;
use serde::Serialize;
use std::marker::PhantomData;

use cosmwasm_std::{Order, StdResult, Storage, KV};
use cosmwasm_std::{Order, Pair, StdResult, Storage};
use std::ops::Deref;

use crate::helpers::nested_namespaces_with_key;
Expand Down Expand Up @@ -42,7 +42,7 @@ impl Bound {
}
}

type DeserializeFn<T> = fn(&dyn Storage, &[u8], KV) -> StdResult<KV<T>>;
type DeserializeFn<T> = fn(&dyn Storage, &[u8], Pair) -> StdResult<Pair<T>>;

#[derive(Clone)]
pub struct Prefix<T>
Expand Down Expand Up @@ -100,7 +100,7 @@ where
min: Option<Bound>,
max: Option<Bound>,
order: Order,
) -> Box<dyn Iterator<Item = StdResult<KV<T>>> + 'a>
) -> Box<dyn Iterator<Item = StdResult<Pair<T>>> + 'a>
where
T: 'a,
{
Expand Down Expand Up @@ -133,7 +133,7 @@ pub fn range_with_prefix<'a>(
start: Option<Bound>,
end: Option<Bound>,
order: Order,
) -> Box<dyn Iterator<Item = KV> + 'a> {
) -> Box<dyn Iterator<Item = Pair> + 'a> {
let start = calc_start_bound(namespace, start);
let end = calc_end_bound(namespace, end);

Expand Down
2 changes: 1 addition & 1 deletion packages/storage-plus/src/snapshot.rs
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ where
min: Option<Bound>,
max: Option<Bound>,
order: cosmwasm_std::Order,
) -> Box<dyn Iterator<Item = StdResult<cosmwasm_std::KV<T>>> + 'c>
) -> Box<dyn Iterator<Item = StdResult<cosmwasm_std::Pair<T>>> + 'c>
where
T: 'c,
{
Expand Down

0 comments on commit 137f326

Please sign in to comment.