Test Windows error #648
Closed
Test Windows error #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
singlepass-windows-error
branch
2 times, most recently
from
be8dc4b to
f299943
Compare
1 task
webmaster128
force-pushed
the
singlepass-windows-error
branch
from
f299943 to
05d9028
Compare
webmaster128
force-pushed
the
upgrade-to-wasmer-reborn
branch
from
cae26f3 to
231af85
Compare
bors bot
added a commit
to wasmerio/wasmer
that referenced
this pull request
Dec 7, 2020
1881: Add UnsupportedTarget error to compiler r=syrusakbary a=webmaster128 Closes #1878 # Description We can error early on for system combinations that are known to not work. This gives users a much better idea why things error and allows adapting the strategy without investing lots of time in debugging. The different behaviour is tested here: - **Old:** _RuntimeErr { msg: "Wasmer runtime error: RuntimeError: call stack exhausted" }_ (CI job "Contract Development / Windows (pull_request)" in CosmWasm/cosmwasm#504) - **New:** _CompileErr { msg: "Could not compile: The target windows is not yet supported (see https://docs.wasmer.io/ecosystem/wasmer/wasmer-features)" }_ (CI job "Contract Development / Windows (pull_request)" in CosmWasm/cosmwasm#648) Something that is not yet clear to me is if `target` is the proper OS source information and if the `Compiler` supports cross compilation where compile evironment is different from runtime environment. # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Simon Warta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.