Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added interpretation and unwrapping of wasmer_runtime_core::error::RuntimeError #359

Merged
merged 24 commits into from
Jun 2, 2020
Merged

added interpretation and unwrapping of wasmer_runtime_core::error::RuntimeError #359

merged 24 commits into from
Jun 2, 2020

Conversation

reuvenpo
Copy link
Contributor

@reuvenpo reuvenpo commented May 22, 2020 •
edited
Loading

This PR will contain further work to interpret errors in Wasmer.
This includes:

This was referenced May 24, 2020
Closed
Merged
@reuvenpo reuvenpo changed the base branch from master to 0.9 May 25, 2020 15:26
reuvenpo added a commit to CosmWasm/wasmd that referenced this pull request May 25, 2020
@reuvenpo
adjusted gas consumption logic in case of errors in go-cosmwasm
398763a 
see:
CosmWasm/wasmvm#90
CosmWasm/cosmwasm#359
This was referenced May 25, 2020
Merged
Closed
Closed
ethanfrey
ethanfrey reviewed May 26, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, just some minor comments.

packages/vm/src/cache.rs Outdated Show resolved Hide resolved
packages/vm/src/errors.rs Show resolved Hide resolved
packages/vm/src/errors.rs Show resolved Hide resolved
ethanfrey
ethanfrey reviewed May 26, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one there.

packages/vm/src/testing/instance.rs Outdated Show resolved Hide resolved
packages/vm/src/instance.rs Outdated Show resolved Hide resolved
@reuvenpo reuvenpo mentioned this pull request May 28, 2020
Merged
@reuvenpo reuvenpo mentioned this pull request Jun 2, 2020
Closed
@reuvenpo reuvenpo removed the request for review from webmaster128 June 2, 2020 18:09
webmaster128
webmaster128 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅❤️

@webmaster128 webmaster128 merged commit 86eebd2 into 0.9 Jun 2, 2020
@webmaster128 webmaster128 deleted the handle-wasmer-errors branch June 2, 2020 19:03
@ethanfrey
Copy link
Member

🎉

alpe pushed a commit to CosmWasm/wasmd that referenced this pull request Jun 9, 2020
@reuvenpo @alpe
adjusted gas consumption logic in case of errors in go-cosmwasm
2974c2e 
see:
CosmWasm/wasmvm#90
CosmWasm/cosmwasm#359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey left review comments

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reuvenpo @ethanfrey @webmaster128