Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Replies test contract #2306

Merged
merged 4 commits into from
Dec 20, 2024
Merged

chore: Replies test contract #2306

merged 4 commits into from
Dec 20, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird force-pushed the tkulik/replies_test_contract branch 5 times, most recently from 157902d to a06d4f1 Compare December 6, 2024 11:30
@kulikthebird kulikthebird marked this pull request as ready for review December 9, 2024 09:35
@kulikthebird kulikthebird self-assigned this Dec 9, 2024
@kulikthebird kulikthebird mentioned this pull request Dec 9, 2024
Open
@kulikthebird kulikthebird force-pushed the tkulik/replies_test_contract branch 5 times, most recently from 99b92a3 to c99e48c Compare December 10, 2024 09:56
@kulikthebird kulikthebird mentioned this pull request Dec 10, 2024
Open
chipshort
chipshort reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you add a CI job for this contract (see e.g. contract_burner in .circleci/config.yml)?
That should also reveal some more clippy lints we should fix.

contracts/replier/src/lib.rs Outdated Show resolved Hide resolved
contracts/replier/src/lib.rs Outdated Show resolved Hide resolved
contracts/replier/src/lib.rs Show resolved Hide resolved
@kulikthebird kulikthebird force-pushed the tkulik/replies_test_contract branch 4 times, most recently from 91079ed to 24c6561 Compare December 17, 2024 11:25
@kulikthebird kulikthebird force-pushed the tkulik/replies_test_contract branch from 3138cad to a71db2b Compare December 19, 2024 18:31
@kulikthebird kulikthebird force-pushed the tkulik/replies_test_contract branch from b9d3791 to 82119d0 Compare December 20, 2024 13:19
chipshort
chipshort approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulikthebird kulikthebird merged commit c8b633e into main Dec 20, 2024
39 checks passed
@kulikthebird kulikthebird deleted the tkulik/replies_test_contract branch December 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

@webmaster128 webmaster128 Awaiting requested review from webmaster128

Assignees

@kulikthebird kulikthebird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulikthebird @chipshort