Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ensure/ensure_eq/ensure_ne macros #1127

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Add ensure/ensure_eq/ensure_ne macros #1127

merged 4 commits into from
Oct 11, 2021

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Oct 7, 2021 •
edited
Loading

Closes #1103

A variant of CosmWasm/cw-plus#474 with the following improvements:

  • precedence testing
  • ensure_ne
  • Let macros not depend on each other to avoid having to import all of them
  • Doc examples with automated testing

ethanfrey
ethanfrey approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

maurolacy
maurolacy approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@webmaster128 webmaster128 merged commit d5ef68d into main Oct 11, 2021
@webmaster128 webmaster128 deleted the add-ensure branch October 11, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@maurolacy maurolacy maurolacy approved these changes

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add require macro
3 participants
@webmaster128 @ethanfrey @maurolacy