Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module size using loupe #1041

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Module size using loupe #1041

merged 5 commits into from
Aug 4, 2021

Conversation

maurolacy
Copy link
Contributor

Closes #959.

Not sure if we want to keep module_size.sh for historical / reference reasons. I'm OK with deleting it, as it may be confusing in the future.

@maurolacy maurolacy requested review from uint and webmaster128 August 4, 2021 09:13
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Not sure if we want to keep module_size.sh for historical / reference reasons. I'm OK with deleting it, as it may be confusing in the future.

Hmm, no strong opinions. We can leave it here for a while and delete later.

packages/vm/src/modules/file_system_cache.rs Outdated Show resolved Hide resolved
@webmaster128 webmaster128 merged commit f7171f5 into main Aug 4, 2021
@webmaster128 webmaster128 deleted the module_size-loupe branch August 4, 2021 10:11
webmaster128 added a commit that referenced this pull request Apr 19, 2023
This essentially reverts #1041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to loupe for determining the size of modules in memory
2 participants