Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify gas running out in wasmer contracts correctly #375

Closed
reuvenpo opened this issue May 26, 2020 · 0 comments · Fixed by #504
Closed

Identify gas running out in wasmer contracts correctly #375

reuvenpo opened this issue May 26, 2020 · 0 comments · Fixed by #504

Comments

@reuvenpo
Copy link
Contributor

tl;dr

This issue is for fixing this TODO, which depends on wasmerio/wasmer fixing this issue wasmerio/wasmer#1452

// TODO: fix the issue described below:

Description

When using the singlepass backend in wasmer, there is an issue when gas runs out.
It should report it as an instance of RuntimeError::Metering, but instead it returns RuntimeError::InvokeError(InvokeError::FailedWithNoError) which is explicitly documented as indicating a bug. When the issue we opened in wasmer is closed, and we update to a version of wasmer that fixes the issue, we need to change the variant that we match against to the correct variant that indicates running out of gas.
NOTE: This will probably mean also downcasting the object inside of RuntimeError::Metering and invastigating it, not just matching against the Metering variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants