Handle gas depletion correctly

CosmWasm · Dec 30, 2020 · 752a3ef · 752a3ef
1 parent b16ad45
commit 752a3ef
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/contracts/hackatom/tests/integration.rs b/contracts/hackatom/tests/integration.rs
@@ -297,8 +297,7 @@ fn handle_panic() {
         &to_vec(&HandleMsg::Panic {}).unwrap(),
     );
     match handle_res.unwrap_err() {
-        // TODO: Don't accept GasDepletion here (https://github.com/CosmWasm/cosmwasm/issues/501)
-        VmError::RuntimeErr { .. } | VmError::GasDepletion { .. } => {}
+        VmError::RuntimeErr { .. } => {}
         err => panic!("Unexpected error: {:?}", err),
     }
 }

diff --git a/packages/vm/src/cache.rs b/packages/vm/src/cache.rs
@@ -510,7 +510,6 @@ mod tests {
     }
 
     #[test]
-    #[ignore] // fails due to the inability to handle gas depletion (https://github.com/wasmerio/wasmer/issues/1931)
     fn recovers_from_out_of_gas() {
         let mut cache = unsafe { Cache::new(make_testing_options()).unwrap() };
         let id = cache.save_wasm(CONTRACT).unwrap();

diff --git a/packages/vm/src/environment.rs b/packages/vm/src/environment.rs
@@ -141,7 +141,19 @@ impl<A: Api, S: Storage, Q: Querier> Environment<A, S, Q> {
             }
             None => Err(VmError::uninitialized_context_data("wasmer_instance")),
         })?;
-        Ok(func.call(args)?)
+
+        func.call(args).map_err(|runtime_err| -> VmError {
+            self.with_context_data(|context_data| match context_data.wasmer_instance {
+                Some(instance_ptr) => {
+                    let instance_ref = unsafe { instance_ptr.as_ref() };
+                    match get_remaining_points(instance_ref) {
+                        MeteringPoints::Remaining(_) => VmError::from(runtime_err),
+                        MeteringPoints::Exhausted => VmError::gas_depletion(),
+                    }
+                }
+                None => VmError::uninitialized_context_data("wasmer_instance"),
+            })
+        })
     }
 
     pub fn with_storage_from_context<C, T>(&self, callback: C) -> VmResult<T>