Stat Analysis Implementation for global-workflow#8
Stat Analysis Implementation for global-workflow#8kevindougherty-noaa wants to merge 84 commits into
Conversation
|
@CoryMartin-NOAA you will need to add Ed and Andrew to be able to review whenever you get a chance. |
|
@ADCollard @EdwardSafford-NOAA feel free to take a look at this. I'll do the same and once we've done a review/test, we will open the PR with the authoritative global-workflow repo. |
This reverts commit 899b20b.
|
I think this is working now but I have a disclaimer/question for people. |
|
My two cents is to take the iterative approach: merge what works now and revisit names/directories in the next round. While developers may exercise the new functionality and get accustomed to the current names/directories, this is a new functionality. As such, we should expect refactoring. While paths and names might change, developers can still benefit from having the output. They can provide feedback on the output (pros & cons) and maybe even develop tools to process the output (e.g., create plots). |
|
Thanks @RussTreadon-NOAA ok, let me open PRs in JCB-GDAS and then GDASApp, then we can start the process of getting this initial capability working in |
|
WCOSS2 g-w CI All jobs in all cases ran to completion. A check of JEDI-based DA cases finds stat the |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Approve based on successful WCOSS2 g-w CI.
Two caveats
- I did not check the stat jobs to ensure that the expected output is correctly generated
- WCOSS2 g-w CI does not run archive (hpss) jobs. HPSS is only exercised when running g-w CI on Hera. If the stat jobs create file(s) written to HPSS, the WCOSS2 tests do not exercise this function.
|
Thank you @RussTreadon-NOAA , do you , @kevindougherty-noaa and @DavidNew-NOAA think this is ready to point this PR at the NOAA-EMC:global-workflow develop branch? |
|
Can we add "Resolves NOAA-EMC#3147" to the description? |
|
@DavidNew-NOAA that will be done when this PR is opened in the authoritative repo and not in my fork |
|
@CoryMartin-NOAA Ah, didn't realize this was a fork |
|
@CoryMartin-NOAA I haven't tested this functionality, but at this point it's far polished up enough to be a PR for GW develop |
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
…noaa/global-workflow into feature/stat-analysis
Thanks @DavidHuber-NOAA, suggestions applied Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
Below are the appropriate changes to run a stat analysis job in the global-workflow.
Additional changes to GDASApp are also needed for
jcb-gdasandjcb-algorithmsfor these scripts to run completely successfully.